drivers: can: mcux: flexcan: move to per-instance message buffer configuration #99483
+285
−88
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
william-tang914
force-pushed
the
feature/move-to-per-instance-message-buffer-configuration
branch
from
9e4b937 to
d8b2c9b
Compare
Fix various formatting issues in NXP device tree files including: - Inconsistent indentation in multi-line interrupt and pll-clocks arrays - Missing spaces around assignment operators - Inconsistent blank line spacing between device tree nodes Also update copyright header in nxp_k6x.dtsi. Signed-off-by: William Tang <william.tang@nxp.com>
Add the `nxp,max-mb` and `nxp,max-mb-fd` device tree property to all NXP FlexCAN controller nodes across various SoC families to specify the maximum number of 8-byte and 64-byte payload message buffers supported by each FlexCAN instance. This change updates device tree source files for multiple NXP SoC families including Kinetis K6x, RT10xx, RT11xx, RT118x, MCX, S32K, S32Z series, and i.MX8MP/i.MX93. The property values are set based on hardware specifications for each specific FlexCAN instance. This property addition ensures proper resource allocation and prevents buffer overflow issues in FlexCAN driver implementations. Signed-off-by: William Tang <william.tang@nxp.com>
william-tang914
force-pushed
the
feature/move-to-per-instance-message-buffer-configuration
branch
from
d8b2c9b to
205defb
Compare
zephyrbot
added
platform: NXP S32
zephyrbot
requested review from
Dat-NguyenDuy,
DerekSnell,
EmilioCBen,
JiafeiPan,
Zhiqiang-Hou,
bperseghetti,
butok,
congnguyenhuu,
dbaluta,
decsny,
dleach02,
iuliana-prodan,
manuargue,
mmahadevan108 and
yangbolu1991
| [FLEXCAN_INST_RX_MB(id)] = {0}; \ | ||
| \ | ||
| static struct mcux_flexcan_tx_callback flexcan_tx_cbs_##id \ | ||
| [FLEXCAN_INST_TX_MB(id)] = {0}; \ |
Contributor
There was a problem hiding this comment.
just query, do we need to consider the case that FLEXCAN_INST_RX_MB(id) or FLEXCAN_INST_TX_MB(id) is 0?
Contributor
Author
There was a problem hiding this comment.
In previous, Kconfig symbol CAN_MAX_FILTER is confined to be greater than 0, but there was no constraint that MCUX_FLEXCAN_MAX_TX not be 0.
If MCUX_FLEXCAN_MAX_TX is 0, compiler will report following warning
zephyrproject/zephyr/drivers/can/can_mcux_flexcan.c:1041:32: warning: array subscript 'alloc' is outside the bounds of an interior zero-length array 'struct mcux_flexcan_tx_callback[0]' [-Wzero-length-bounds]
1041 | function = data->tx_cbs[alloc].function;
For safety, I think it would be better to confine FLEXCAN_INST_TX_MB(id) and FLEXCAN_INST_RX_MB(id) greater than 0.
This change refactors the FlexCAN driver to use per-instance message buffer configuration instead of global Kconfig options. The driver now calculates message buffer allocation at compile time based on device tree properties for each FlexCAN instance. Key changes: - Remove global CAN_MAX_MB Kconfig option and associated range constraint - Add max_mb, rx_mb, and tx_mb fields to mcux_flexcan_config structure - Move callback arrays and atomic allocation bitmaps from static global arrays to per-instance static arrays generated by macros - Update data structure to use pointers to per-instance arrays instead of fixed-size embedded arrays - Add compile-time validation to ensure sufficient message buffers are available for required RX filters and RX filters greater than 0 This approach allows different FlexCAN instances to have different message buffer configurations based on their hardware capabilities and device tree settings, improving memory efficiency and flexibility. The change maintains backward compatibility while enabling better resource utilization across different SoC variants. Fixes zephyrproject-rtos#92798 Signed-off-by: William Tang <william.tang@nxp.com>
william-tang914
force-pushed
the
feature/move-to-per-instance-message-buffer-configuration
branch
from
205defb to
ee6a72b
Compare
|
zejiang0jason
approved these changes
Nov 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change refactors the FlexCAN driver to use per-instance message buffer configuration instead of global Kconfig options. The driver now calculates message buffer allocation at compile time based on device tree properties for each FlexCAN instance.
Key changes:
This approach allows different FlexCAN instances to have different message buffer configurations based on their hardware capabilities and device tree settings, improving memory efficiency and flexibility. The change maintains backward compatibility while enabling better resource utilization across different SoC variants.
Fixes #92798